lorentz/wulf-pulse
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

fix(09): ThemeSessionBridge ignores server 'system' to preserve existing client theme

Browse source 
Migration 084 backfilled theme='system' for all existing users. The bridge
was then calling setTheme('system') on every signed-in client, clobbering
existing localStorage values (e.g. user previously chose 'dark', got reset
to OS preference). Treat server 'system' as 'no explicit opinion' — only
enforce explicit 'light'/'dark' from the server.

Tradeoff: explicit 'system' selection on one device won't propagate to a
device that has 'light'/'dark' cached. Acceptable — users can re-select.
This commit is contained in:
lorentz 2026-05-10 21:54:04 -04:00
parent 58816bbdfe
commit 2a3e89c753
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/mobile/profile/ThemeSessionBridge.tsx
View file

@ -23,11 +23,11 @@ export function ThemeSessionBridge() {
useEffect(() => {
if (!session?.user) return;
const serverTheme = (session.user as SessionUserWithTheme).theme;
if (
serverTheme === 'light' ||
serverTheme === 'dark' ||
serverTheme === 'system'
) {
// Only enforce explicit choices. 'system' is the column default and may
// mean "no opinion yet" — don't clobber a user's existing client preference
// (especially relevant on first load after the migration that backfilled
// every existing user to 'system').
if (serverTheme === 'light' || serverTheme === 'dark') {
if (serverTheme !== theme) {
setTheme(serverTheme);
}