lorentz/wulf-pulse
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions
wulf-pulse/app/api
History
Exact
lorentz e057255f4f fix(24): address code-review findings — PATCH identity guard, empty-array tombstone, health-check timeout, record-key normalization 
Two critical issues from the post-phase code review:

- PATCH /api/route53/zones/[zoneId]/records/[recordId] never verified the
  request body's name/type/setIdentifier matched the record identified by
  the URL. A mismatch would silently UPSERT a brand-new AWS recordset
  (leaving the original live and untouched) while corrupting the mirror's
  record_key invariant. Now rejects with 400 if any of those three fields
  differ from the existing record — renaming/retyping is delete-plus-create,
  not an update.

- route53-sync-service.ts's syncZones()/syncRecords() tombstone queries used
  "id <> ALL(seenIds)" style queries with no empty-array guard — a
  successful-but-empty AWS response would soft-delete every previously
  synced zone/record in one shot. Same bug class already fixed in
  pax8-sync-service.ts; now guarded the same way here.

Two smaller fixes:

- checkRoute53()'s AWS auth probe had no timeout, unlike every other
  integration's liveCheck() (8s AbortController). Added the same bound via
  the SDK's abortSignal option.
- buildRecordKey() relied on every caller to pre-normalize name/type case
  before calling it. Now normalizes internally (lowercase name, uppercase
  type) so the record_key invariant holds regardless of caller discipline.

Full REVIEW.md findings in 24-REVIEW.md. Two remaining Warnings (alias
records un-editable/undeletable, no admin-UI surface for route53_audit_log)
deliberately left as backlog items for a follow-up phase — out of scope for
a post-execution fix pass.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-05 23:15:27 -04:00
..
addigy/org-mappings Add comprehensive admin features and multi-system integration 2025-11-19 14:18:16 -05:00
addigy-devices Restructure: rename to Pulse and move app to root 2025-10-28 23:08:54 -04:00
addigy-policies Restructure: rename to Pulse and move app to root 2025-10-28 23:08:54 -04:00
admin feat(23-03): add admin phishing-automation GET/PATCH/DELETE routes 2026-07-16 19:37:06 -04:00
analyzer feat(admin): client scope — filter analytics to recurring-revenue companies 2026-05-03 11:40:47 -04:00
appgate feat(appgate): add AppGate SDP integration health check and sync service 2026-07-11 09:43:48 -04:00
auth/[...all] feat: add authentication, user management, and admin features 2026-01-31 12:43:14 -05:00
auvik feat: auto-populate auvik_tenants and rmm_sites tables when fetching mappings 2026-02-02 23:12:35 -05:00
companies feat: IT Glue integration, workflow engine, pipelines, Zabbix WAN, notification channels, backup status UI improvements, nav alignment fixes 2026-02-27 14:52:14 -05:00
config-enrichment Restructure: rename to Pulse and move app to root 2025-10-28 23:08:54 -04:00
config-items/[id]/tickets Restructure: rename to Pulse and move app to root 2025-10-28 23:08:54 -04:00
configuration-items Add comprehensive admin features and multi-system integration 2025-11-19 14:18:16 -05:00
contacts Add comprehensive admin features and multi-system integration 2025-11-19 14:18:16 -05:00
dashboard chore: check in pending work — queue preferences, QBO AR diagnostics, mobile engagement fixes, ops scripts 2026-07-18 06:34:57 -04:00
data fix(14): cast companies-list id to Number to match resolve route's z.number() schema 2026-07-11 15:16:38 -04:00
datto-rmm/sync feat: Autotask webhook integration, TicketNotes, Datto RMM, workflow engine, Veeam agents/alarms, AI triage, misc improvements 2026-02-20 10:28:15 -05:00
debug-auth Restructure: rename to Pulse and move app to root 2025-10-28 23:08:54 -04:00
duo feat: Separate bypass vs disabled users in Duo UI 2026-03-27 11:41:52 -04:00
engagement feat(engagement): replace Graph email counts with real-time mimecast data 2026-06-02 20:25:14 -04:00
health Restructure: rename to Pulse and move app to root 2025-10-28 23:08:54 -04:00
integrations/status feat: Autotask webhook integration, TicketNotes, Datto RMM, workflow engine, Veeam agents/alarms, AI triage, misc improvements 2026-02-20 10:28:15 -05:00
invoices/[id]/line-items Restructure: rename to Pulse and move app to root 2025-10-28 23:08:54 -04:00
itglue feat: QuickBooks Online integration 2026-03-17 07:39:55 -04:00
kiosk feat: Display Settings UI + Company Category/Type sync 2026-04-06 09:03:19 -04:00
me chore: check in pending work — queue preferences, QBO AR diagnostics, mobile engagement fixes, ops scripts 2026-07-18 06:34:57 -04:00
mimecast feat: mailbox remediation via Graph Mail.ReadWrite — search + move to Deleted Items from analysis dialog 2026-04-01 10:09:38 -04:00
mobile chore: check in pending work — queue preferences, QBO AR diagnostics, mobile engagement fixes, ops scripts 2026-07-18 06:34:57 -04:00
notification-channels feat(09-06): owner column + role-scoped reads on notification channels 2026-05-10 07:39:53 -04:00
notifications/morning-summary feat: Morning NOC Summary adaptive card for Teams 2026-03-11 09:34:51 -04:00
openclaw feat: Duo Security integration — full data sync from Accounts + Admin API 2026-03-27 09:18:04 -04:00
pax8 chore: merge executor worktree (worktree-agent-a11c767c2a8721d5b) 2026-07-11 14:31:20 -04:00
phishing feat(260717-v6c): add POST /api/phishing/campaigns/[id]/mark-accidental-report route 2026-07-17 22:33:09 -04:00
picklists Restructure: rename to Pulse and move app to root 2025-10-28 23:08:54 -04:00
pipelines feat: IT Glue integration, workflow engine, pipelines, Zabbix WAN, notification channels, backup status UI improvements, nav alignment fixes 2026-02-27 14:52:14 -05:00
qbo chore: check in pending work — queue preferences, QBO AR diagnostics, mobile engagement fixes, ops scripts 2026-07-18 06:34:57 -04:00
reports/ticket-digest feat: QuickBooks Online integration 2026-03-17 07:39:55 -04:00
resources Restructure: rename to Pulse and move app to root 2025-10-28 23:08:54 -04:00
rmm feat: RMM Overshell, IT Glue audit/write-back, LogLift, link-aware bundles, dashboard overhaul 2026-05-03 07:13:18 -04:00
rmm-audit Restructure: rename to Pulse and move app to root 2025-10-28 23:08:54 -04:00
rmm-devices Add comprehensive admin features and multi-system integration 2025-11-19 14:18:16 -05:00
rmm-test Restructure: rename to Pulse and move app to root 2025-10-28 23:08:54 -04:00
route53 fix(24): address code-review findings — PATCH identity guard, empty-array tombstone, health-check timeout, record-key normalization 2026-08-05 23:15:27 -04:00
salesbldr/quotes feat: add authentication, user management, and admin features 2026-01-31 12:43:14 -05:00
sentinelone feat: Add SentinelOne integration 2026-02-27 05:31:31 -05:00
settings/profile fix: "user" table writes use "updatedAt" not updated_at 2026-05-10 23:03:36 -04:00
status/workers feat(status): 24-hour activity sparklines on worker pulse cards 2026-05-03 10:03:54 -04:00
sync feat(260521-fci-01): add ticket reconciliation service + API route 2026-05-21 11:08:24 -04:00
tasks Restructure: rename to Pulse and move app to root 2025-10-28 23:08:54 -04:00
test-zones Restructure: rename to Pulse and move app to root 2025-10-28 23:08:54 -04:00
ticket-workflows feat: IT Glue integration, workflow engine, pipelines, Zabbix WAN, notification channels, backup status UI improvements, nav alignment fixes 2026-02-27 14:52:14 -05:00
tickets perf: switch ticket modal from live API to Postgres 2026-03-23 11:09:29 -04:00
veeam feat: Veeam RPO analysis, comparison, ticket analysis + company teams table 2026-04-29 09:16:46 -04:00
webhooks feat: repo commit tracking and OpenClaw notification 2026-03-21 18:52:22 -04:00
workflow feat: Autotask webhook integration, TicketNotes, Datto RMM, workflow engine, Veeam agents/alarms, AI triage, misc improvements 2026-02-20 10:28:15 -05:00
zabbix feat: QuickBooks Online integration 2026-03-17 07:39:55 -04:00
zoom/sync feat: Morning NOC Summary adaptive card for Teams 2026-03-11 09:34:51 -04:00