Commit graph

954 commits

Author SHA1 Message Date
b3048be769 feat(24-07): zones, records, and history page shell for /admin/sync/route53
- Four-tab detail page (Zones / Records / History / Schedule) following
  the veeam/pax8 sync-detail-page shape
- Sync Now trigger with bounded polling and 409/503 handling
- Records tab: zone selector, type/search filters, actions cell gated on
  the D-01 writable-type allowlist (NS/SOA render read-only)
- History tab: per-record change ledger with pulse_crud vs
  sync_detected_drift source badges (D-06)
- Zone/history detail drill-downs via the existing DetailModal component
2026-08-05 20:52:25 -04:00
493d6daf6c docs(phase-24): update tracking after wave 3 (plans 24-05, 24-06 complete)
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-05 20:39:58 -04:00
c47de2a91c chore: merge executor worktree (worktree-agent-a8fd5f9961335cf8d) — plan 24-05 2026-08-05 20:38:35 -04:00
78e534cafc chore: merge executor worktree (worktree-agent-a09d891460d61dc86) — plan 24-06 2026-08-05 20:38:35 -04:00
5e1b8aae75 docs(24-05): add plan summary
Route 53 API surface — read routes, sync trigger, CRUD write routes with
pending/committed/failed audit lifecycle.
2026-08-05 20:37:55 -04:00
a7d6a04110 feat(24-05): CRUD write routes with pending/committed/failed audit lifecycle
- app/api/route53/zones/[zoneId]/records/route.ts: add POST (create)
- app/api/route53/zones/[zoneId]/records/[recordId]/route.ts: PATCH (update), DELETE
- All three write handlers: requireAdmin() first (D-04), validateRecordWrite() before
  any AWS command (D-01), createPendingAuditLog() before submitRecordChange() (D-07/SC-3)
- Committed path: markAuditCommitted -> insertPulseCrudHistory (pulse_crud, SC-4) ->
  mirror refresh; failed path: sanitizeAwsError -> markAuditFailed -> 502, no history row
- DELETE submits the exact mirror-read recordset (name/type/ttl/resourceRecords), never
  client-supplied values, per Route 53's exact-match delete requirement
- recordId zone-prefix mismatch guard (T-24-17): 400 before any audit row or AWS call
- No staged-approval mechanism anywhere (D-03) — mutation executes on first request
- tsc clean; npm test 554/556 passing (2 pre-existing itglue-search failures, unrelated,
  logged in deferred-items.md, already documented by plans 24-01/24-03)
2026-08-05 20:36:54 -04:00
53ec51c5e0 feat(24-05): read routes for zones, records, history, and sync status
- app/api/route53/sync/route.ts: POST (requireAdmin, fire-and-forget) + GET (requireAuth, status/history)
- app/api/route53/zones/route.ts: GET (requireAuth) list mirrored hosted zones
- app/api/route53/zones/[zoneId]/records/route.ts: GET (requireAuth) list records with type/search filters
- app/api/route53/zones/[zoneId]/records/[recordId]/history/route.ts: GET (requireAuth) append-only change ledger
- None gated on integration_settings disable toggle (D-10 — route53 is not a PAX8-style exception)
- /api/route53 confirmed absent from middleware.ts public-route list
- tsc clean
2026-08-05 20:33:58 -04:00
82408733a4 docs(24-06): append self-check results to plan summary 2026-08-05 20:33:26 -04:00
8fcf587a30 docs(24-06): create plan summary 2026-08-05 20:33:08 -04:00
f4e151dedd feat(24-05): implement route53-change-submit (ChangeBatch, retry, bounded poll)
- buildChangeBatch: CREATE/UPSERT/DELETE, SetIdentifier omission, NS/SOA guard (D-01 defence in depth)
- isRetryableAwsError: classifies ThrottlingException/Throttling/PriorRequestNotComplete/ServiceUnavailable
- submitRecordChange: sends ChangeResourceRecordSetsCommand with bounded 2-retry backoff (750ms/1500ms)
- pollChangeStatus: bounded 15s/2s GetChange poll, no 30-minute SDK waiter
- 20/20 tests passing, tsc clean
2026-08-05 20:31:43 -04:00
6627cee925 feat(24-06): add Route 53 tile to /admin/sync integration list
- Hand-authored public/logos/route53.svg (globe/DNS glyph, primitive
  shapes only, no script/external refs/raster data)
- New INTEGRATIONS entry linking to /admin/sync/route53 (built in
  plan 24-07), color: orange (already used by datto-rmm)
2026-08-05 20:31:26 -04:00
fee1f9962b feat(24-06): wire route53-incremental/route53-full into sync scheduler
- Add route53-incremental and route53-full to the sync_type union
- Seed both schedules disabled (*/15 * * * * incremental, 0 1 * * * full)
- Dispatch branches gate on isRoute53Configured() only (D-10 — no
  integration_settings check, unlike the pax8-daily exception)
- Both branches use dynamic import to keep the AWS SDK out of the
  scheduler's eager module graph
2026-08-05 20:30:52 -04:00
9a9e691cd4 test(24-05): add failing test for route53-change-submit
- ChangeBatch construction (CREATE/UPSERT/DELETE, SetIdentifier omission, NS/SOA guard)
- isRetryableAwsError classification
- submitRecordChange retry-with-backoff behavior
- pollChangeStatus bounded polling (INSYNC / timeout / per-attempt error swallow)
2026-08-05 20:29:57 -04:00
2b009573c4 docs(phase-24): update tracking after wave 2 (plans 24-02, 24-03, 24-04 complete)
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-05 20:27:11 -04:00
e727ddca77 refactor(24): consolidate duplicate sanitizeAwsError into single source
Plan 24-04's isolated worktree didn't have plan 24-03's
route53-record-validation.ts available (parallel wave, no direct
dependency), so it carried a local copy of the identical AWS error
redaction logic — flagged in its own SUMMARY for consolidation once
24-03 merged. Both plans are now merged; importing the shared
implementation instead of keeping two copies in sync.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-05 20:27:01 -04:00
d00c47ecb1 chore: merge executor worktree (worktree-agent-a30d26dba3410e0da) — plan 24-04 2026-08-05 20:26:13 -04:00
2dbb1e13e2 chore: merge executor worktree (worktree-agent-ab77d007f6dbb3578) — plan 24-03 2026-08-05 20:26:13 -04:00
d7f72f8507 chore: merge executor worktree (worktree-agent-a6d587bad9f0efdb8) — plan 24-02 2026-08-05 20:26:13 -04:00
416abe98a0 docs(24-04): create plan summary
- Route 53 registered in integration health with D-12 live NS-delegation check
- Records EGRESS-OK path taken (Node dns module, no DoH fallback needed)
- Documents local sanitizeAwsError duplication vs plan 24-03 (parallel worktree gap)
2026-08-05 20:25:33 -04:00
ea04672e5b feat(24-04): register checkRoute53() in the integration health aggregator
- checkRoute53(): config gate + ListHostedZonesCommand auth probe, mirrors
  checkDattoRmm()'s custom-body shape (key: 'route53', category: 'network')
- Auth-probe errors classified via isAwsAuthError (InvalidClientTokenId,
  SignatureDoesNotMatch, AccessDenied, UnrecognizedClientException, 401/403)
  and redacted through a local sanitizeAwsError before reaching IntegrationHealth.error
- D-12: queries route53_zones (is_deleted=false, capped at 50 by name),
  feeds checkAllZoneDelegations(); mismatches downgrade status to a new
  'degraded' HealthStatus member; lookup failures reported separately via
  nsDelegationErrors, never counted as mismatches
- Whole delegation step wrapped in try/catch so a Postgres failure or
  blocked resolver can never abort checkIntegrationHealth()'s Promise.all (T-24-16)
- summarize() updated so 'degraded' counts toward failed/hasIssues instead
  of falling through uncounted (Rule 1 fix)
- No changes to applyDisableOverlay() — route53 covered by the existing
  generic by-key overlay (D-10)
2026-08-05 20:24:36 -04:00
6df084cb98 docs(24-02): create plan summary
Route 53 sync + drift detection plan complete: 3 tasks, 4 files, all
verification passing (22 new tests, tsc clean, full suite green aside from
pre-existing unrelated itglue-search failures).
2026-08-05 20:24:18 -04:00
3d2680c47f docs(24-03): add plan summary
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-05 20:23:24 -04:00
0acf1fa24f test(24-02): cover buildDriftHistoryRows update/delete/create/no-change cases
- 6 unit tests exercising the pure drift-classification wiring in Route53SyncService
- Confirms whole-recordset before/after payloads, not per-field deltas
- Confirms CRUD-originated changes still get tagged sync_detected_drift (sync cannot distinguish actor)
- Full suite green aside from 2 pre-existing itglue-search.test.ts failures logged in deferred-items.md (unrelated to this plan)
2026-08-05 20:23:16 -04:00
d8c0912f4b feat(24-02): add Route53SyncService — zones and records mirror sync
- fullSync/incrementalSync + getRoute53SyncService() singleton
- Paginated ListHostedZonesCommand + GetHostedZoneCommand (delegation set for D-12)
- Paginated ListResourceRecordSetsCommand per live zone
- Soft-delete reconciliation for zones and records (never hard-delete)
- sync_history bookkeeping with entity_type='route53', literal full/incremental sync_type
- Drift detection wired via buildDriftHistoryRows, writing sync_detected_drift history rows
- No integration_settings gating anywhere (D-10)
2026-08-05 20:22:34 -04:00
8b5e926bb1 feat(24-03): add Route 53 audit lifecycle and pulse_crud history persistence
- createPendingAuditLog/markAuditCommitted/markAuditFailed implement the pending -> committed/failed lifecycle (D-07, SC-3); markAuditFailed always sanitizes via sanitizeAwsError
- insertPulseCrudHistory writes 'pulse_crud' history rows, documented as callable only after a committed write
- upsertMirrorRecord/softDeleteMirrorRecord/loadMirrorRecord manage the route53_records mirror; mirror writes are best-effort and soft-delete only (D-08), audit/history writes are not best-effort
- log same pre-existing itglue-search.test.ts failures (unrelated, out of scope) in deferred-items.md
2026-08-05 20:22:24 -04:00
06ebae5a5c feat(24-04): implement NS normalization and delegation-comparison module
- normalizeNsList: lowercase, strip trailing dot, dedupe, sort, [] for non-arrays
- compareNsDelegation: set-diff mismatch with unjudgeable-empty-authoritative guard
- resolveLiveNs: dedicated dns.Resolver() pinned to 1.1.1.1/8.8.8.8, never touches
  the process-global resolver (D-12, T-24-13)
- checkAllZoneDelegations: bounded-concurrency batch check, lookup errors reported
  separately from mismatches (T-24-14)
2026-08-05 20:21:30 -04:00
c18271dda9 test(24-02): add Route 53 record-key, normalization, and drift-classification helpers
- buildRecordKey, normalizeRecordSet, recordSetsEqual, classifyDrift, toHistoryPayload
- Pure, dependency-free module (no pg, no AWS client construction)
- 16 unit tests covering every behavior bullet from the plan
2026-08-05 20:21:05 -04:00
4be4a191a5 feat(24-03): add D-01 record-write validator and AWS error sanitizer
- validateRecordWrite enforces closed allowlist (A/AAAA/CNAME/MX/TXT/SRV), rejects NS/SOA case-insensitively with a delegation-specific reason
- sanitizeAwsError redacts AWS access key ids, ARNs, and 12-digit account ids, truncates to 500 chars (T-24-03)
- no AWS SDK or Postgres dependency; fully unit-tested (23 assertions)
2026-08-05 20:20:46 -04:00
7396f07f2e test(24-04): add failing test for NS normalization and delegation comparison
- normalizeNsList: lowercase, strip trailing dot, dedupe, sort, [] for non-arrays
- compareNsDelegation: set-diff mismatch detection with unjudgeable-empty-authoritative guard
2026-08-05 20:20:41 -04:00
ecd4dabd67 docs(phase-24): update tracking after wave 1 (plan 24-01 complete)
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-05 20:17:42 -04:00
2eb6c2884c chore: merge executor worktree (worktree-agent-aa690b9b15c5b0f8e) — plan 24-01 2026-08-05 20:16:56 -04:00
b81ad3ecc2 docs(24-01): resolve checkpoint — BWS key rename confirmed, DNS egress OK
Checkpoint task 3 resolved: BWS secret keys renamed in Bitwarden
(AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY confirmed present), DNS egress
to public resolvers confirmed OK, credentials confirmed reaching the
Node process. IAM scope left as an open operational item for the
developer to confirm via AWS console.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-05 20:16:45 -04:00
97ec5722b1 docs(24-01): create partial SUMMARY, checkpoint pending
Tasks 1-2 complete (AWS SDK + schema migration, types + credential factory).
Task 3 is a blocking human-verify checkpoint requiring BWS/AWS credential
confirmation and live docker/DNS-egress verification — not fabricated, not
run unilaterally. Execution stops here pending developer response.
2026-08-05 19:26:46 -04:00
fadae68fe4 docs(24-01): log pre-existing itglue-search test failures as out-of-scope
Unrelated to Route 53 factory/schema work; not fixed per scope boundary rule.
2026-08-05 19:25:39 -04:00
210f84d343 feat(24-01): implement Route 53 credential factory
- lib/services/route53-factory.ts: isRoute53Configured() / getRoute53Client()
  / resetRoute53Client(), following the veeam-factory.ts singleton shape
- No explicit credentials option passed to Route53Client — relies on the AWS
  SDK's default credential chain reading AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY
  from process.env, exactly how BWS injects them at the container entrypoint
- CLAUDE.md: document the AWS_* env-prefix exception in the integration table
- All 7 route53-factory.test.ts assertions pass; npx tsc --noEmit clean
2026-08-05 19:25:36 -04:00
4dd9d5dab8 test(24-01): add failing test for Route 53 credential factory
- lib/types/route53.ts: camelCase interfaces for zones/records/history/audit-log/sync-result
- lib/services/route53-factory.test.ts: isRoute53Configured() + getRoute53Client() behavior
  cases — fails RED, factory module does not exist yet
2026-08-05 19:24:28 -04:00
b9df27b656 feat(24-01): install AWS Route 53 SDK and create dedicated schema migration
- Add @aws-sdk/client-route-53 dependency (official aws-sdk-js-v3 package)
- Add migrations/102_route53_tables.sql: route53_zones, route53_records,
  route53_record_history (D-06 change ledger), route53_audit_log
  (D-03/D-07 attempt audit log with pending/committed/failed status)
- Seed integration_settings row for key='route53' (D-10, display-only toggle)
- Unbounded retention by design (D-08) — no purge job, no TTL, no DELETE
2026-08-05 19:23:43 -04:00
602c3bb7b5 docs(24): create phase plan 2026-08-05 19:18:13 -04:00
0eab4996e9 docs(24): add pattern map 2026-08-05 19:18:00 -04:00
998c4b1a36 docs(24): research phase domain for AWS Route 53 DNS sync 2026-08-05 19:17:59 -04:00
52affe348c docs(24): cite D-02/D-05/D-08/D-09 in plan must_haves 2026-08-05 19:17:35 -04:00
15e52280b5 docs(24): create phase plan — 7 plans in 4 waves for AWS Route 53 DNS sync 2026-08-05 19:09:15 -04:00
6ad27fcbb6 docs(phase-24): add validation strategy 2026-08-05 18:46:43 -04:00
e289f2d24f docs(state): record phase 24 context session 2026-08-05 18:31:11 -04:00
0805e387e3 docs(24): capture phase context 2026-08-05 18:31:06 -04:00
5f308f836f fix(phishing-recipient-seubert): scope campaign grouping Tier 3 to company, not reporting contact
Tier 3 is the only tier automatic (webhook-triggered) grouping ever
reaches, since grouping runs before message parsing. It was scoped to
reports.requester_contact_id, so the same campaign reported by
different employees at the same company never consolidated into one
campaign — each report's evidence/blast-radius view silently
under-reported the campaign's true recipients.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-22 12:34:33 -04:00
e9478101a3 docs(quick-260721-n49): fix classifier to resolve per-company Mimecast tenant instead of the global tenant 2026-07-21 16:48:11 -04:00
1cd0d4db48 chore: merge quick task worktree (worktree-agent-a498794d9a221b8b7) 2026-07-21 16:47:36 -04:00
9f12cd610a test(260721-n49): cover tenant-scoped vs global-fallback getBlastRadius branches
- Add mimecast_tenants routing branch to stageQueries and company_id to
  report fixtures
- New test: enabled mimecast_tenants row -> getBlastRadius called with
  { client, cacheScope: companyId } and the tenant SQL is issued
- New parameterized test: null companyId and companyId-with-no-enabled-row
  -> getBlastRadius called with no second argument (global fallback)
2026-07-21 16:45:44 -04:00
9f75f2160c fix(260721-n49): resolve per-company Mimecast tenant in gatherCampaignEvidence
- Thread company_id through reports query and CampaignReportSummary
- Mirror the route's Bug 2 (D-05) tenant-resolution block: query
  mimecast_tenants for an enabled row, build a tenant-scoped client via
  getMimecastClientForTenant, and pass { client, cacheScope } to
  getBlastRadius() when one exists
- Preserve global env fallback unchanged when no companyId or no
  enabled tenant row is present
2026-07-21 16:44:44 -04:00